Fill Memcached::__construct() parameters description#4263
Open
alexandre-daubois wants to merge 1 commit intophp:masterfrom
Open
Fill Memcached::__construct() parameters description#4263alexandre-daubois wants to merge 1 commit intophp:masterfrom
Memcached::__construct() parameters description#4263alexandre-daubois wants to merge 1 commit intophp:masterfrom
Conversation
Girgias
reviewed
Dec 6, 2024
alexandre-daubois
force-pushed
the
memcached-params
branch
2 times, most recently
from
1ae2459 to
c5732d3
Compare
Girgias
reviewed
Dec 10, 2024
| <methodsynopsis> | ||
| <type>void</type><methodname><replaceable>callback</replaceable></methodname> | ||
| <methodparam><type>Memcached</type><parameter>memcached</parameter></methodparam> | ||
| <methodparam><type>string</type><parameter>persistent_id</parameter></methodparam> |
Member
There was a problem hiding this comment.
Looking at the linked source code this should be string|null
Member
Author
There was a problem hiding this comment.
Ah yes, I missed the if. Not a pro of PHP extensions and C, but I would say you're right 😄 Updated
alexandre-daubois
force-pushed
the
memcached-params
branch
from
c5732d3 to
45b05e5
Compare
philip
reviewed
Mar 4, 2025
| <methodsynopsis> | ||
| <type>void</type><methodname><replaceable>callback</replaceable></methodname> | ||
| <methodparam><type>Memcached</type><parameter>memcached</parameter></methodparam> | ||
| <methodparam><type>string|null</type><parameter>persistent_id</parameter></methodparam> |
Member
There was a problem hiding this comment.
We have fun markup for this, so rather than <type>string|null</type> here use <type class="union"><type>string</type><type>null</type></type> instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #4025